Skip to content
This repository was archived by the owner on Feb 12, 2022. It is now read-only.

Update the README. Fixes grammar mistakes, adjusts examples to better… - #7

Merged
cmcculloh-kr merged 5 commits into
ExactTarget:masterfrom
gdborton:master
Aug 18, 2015
Merged

cmcculloh-kr merged 5 commits into
ExactTarget:masterfrom
gdborton:master

Conversation

@gdborton

Copy link
Copy Markdown
Contributor

… conform with guide, and removes non relevant pieces.

… conform with guide, and removes non relevant pieces.
@gdborton

Copy link
Copy Markdown
Contributor Author

@cmcculloh Hey, could you take a look at this? Largely it is grammatical, and fixes a few issues where the examples don't conform with the style guide.

Comment thread README.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The space is required. Having a space between function and () helps to indicate that "function" is not the name of the function, and that this is an un-named anonymous function.

@cmcculloh

Copy link
Copy Markdown
Contributor

Thanks @gdborton! I liked a lot of these changes, but had a few concerns.

@gdborton

gdborton commented Aug 7, 2015

Copy link
Copy Markdown
Contributor Author

@cmcculloh Thanks for the feedback, I think I responded to everything. It's awesome that you're so thorough.

Comment thread README.md Outdated

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmcculloh added this back in here. Also, corrected anonymous functions throughout the readme.

@cmcculloh

Copy link
Copy Markdown
Contributor

Awesome @gdborton, thanks! This all looks good to me. Thank you for your work!

I'm going to give this until Monday for any of the other UXAs to weigh in before merging.

Comment thread README.md Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oop! Sorry @gdborton , just noticed you missed one here... Should be var anonymous = function () {

@gdborton

Copy link
Copy Markdown
Contributor Author

@cmcculloh Updated the anonymous functions to include a space before the paren (was some confusion on my part). Also fix the missing semicolon.

Comment thread README.md Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gdborton oops, looks like we got an errant space in the "bad" example. Should probably be function() { for the "bad" example.

@cmcculloh-kr

Copy link
Copy Markdown

One last thing and I'll merge. Thanks!

@gdborton

Copy link
Copy Markdown
Contributor Author

Updated.

cmcculloh-kr pushed a commit that referenced this pull request Aug 18, 2015
Update the README. Fixes grammar mistakes, adjusts examples to better…
@cmcculloh-kr
cmcculloh-kr merged commit 9f97de3 into ExactTarget:master Aug 18, 2015
@cmcculloh-kr

Copy link
Copy Markdown

Thank you sir!!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants