Repository navigation
fix: ignore IN and FROM inside CASE when detecting named-parameter st… - #2940
Open
harryfoster2006 wants to merge 1 commit into
Open
harryfoster2006 wants to merge 1 commit into
harryfoster2006 wants to merge 1 commit into
Conversation
…ring functions Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ring functions
isNamedExprListAhead() scans a string function's arguments (SUBSTR, POSITION and similar) to decide whether to parse them as a named-parameter list (SUBSTR(x FROM 1 FOR 2), POSITION(a IN b)). The scan looks for top-level IN and FROM keywords. It didn't know about CASE ... END, so an IN predicate inside a CASE branch was treated as the function's own IN. That sent the parser down the wrong path and the statement failed to parse:
Fix
The lookahead now tracks
CASEnesting with a caseDepth counter. While inside aCASE ... END, tokens are skipped, soINandFROMthere are no longer mistaken for the function's keywords. NestedCASEexpressions are handled because the counter increments and decrements.