Repository navigation
fix: parse WITH NO SCHEMA BINDING on CREATE VIEW - #2941
Open
harryfoster2006 wants to merge 1 commit into
Open
harryfoster2006 wants to merge 1 commit into
harryfoster2006 wants to merge 1 commit into
Conversation
Redshift late-binding views end with WITH NO SCHEMA BINDING. Accept the clause after the view query, keep it on CreateView and deparse it. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redshift late-binding views end with
WITH NO SCHEMA BINDING, so this fails to parse:CreateViewonly acceptedWITH READ ONLY,WITH [CASCADED|LOCAL] CHECK OPTIONandWITH [NO] DATAafter the query.Syntax reference: https://docs.aws.amazon.com/redshift/latest/dg/r_CREATE_VIEW.html
Change
WITH NO SCHEMA BINDINGafter the view query. A two-token lookahead onNO SCHEMAkeeps it distinct fromWITH NO DATA.BINDINGis a contextual keyword, so it is not reserved.CreateView: newwithNoSchemaBindingflag with getter, setter andwithWithNoSchemaBinding(...), emitted byappendOptionsAfterQueryTo, so bothtoString()andCreateViewDeParserround-trip it.RedshiftCreateViewTest.lateBindingViewcovers a parenthesised select,OR REPLACEwith a schema-qualified name and column list, and the flag being set.