Repository navigation
fix: parse arithmetic after subqueries in BETWEEN bounds - #2946
Open
hutiefang76 wants to merge 1 commit into
Open
hutiefang76 wants to merge 1 commit into
hutiefang76 wants to merge 1 commit into
Conversation
Use the existing arithmetic continuation for parenthesized subqueries in both BETWEEN bounds. Check the reported expressions and their parsed node types. Refs JSQLParser#2944
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2944.
A parenthesized subquery at the start of a
BETWEENbound previously stopped parsing at the closing parenthesis. Both bounds now continue through the existing arithmetic parser. The regression cases cover subtraction, an interval and addition, with checks on the resulting expression nodes../gradlew --offline --no-daemon checkpassed, including all 14BetweenTestcases and the JavaCC grammar ambiguity check.mvn clean verifypassed before the final test formatting change.AI assistance: DeepSeek and OpenAI Codex assisted implementation and review. I ran the tests and benchmark locally.