Repository navigation
fix(policy): align request authorization with route protocol - #5274
Conversation
|
🌿 Preview your docs: https://nvidia-preview-pr-5274.docs.buildwithfern.com/openshell |
Compatibility review (advisory)New or updated breaking changes; see the full report for all findings. 1. policy — No explicit risk acceptance foundMatching HTTP endpoints previously combined allows across protocols; now only endpoints using the most-specific path-selected protocol contribute allows.
Review details
Advisory review; publication gates are unchanged. |
|
Label |
johntmyers
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
The independent review found no blocking defects in the route-protocol authorization fix. The change preserves additive allows within the selected protocol, deny precedence, and credential ownership checks, with regression coverage and updated policy documentation.
The standard E2E suite is queued on the current head after applying test:e2e and rerunning all jobs as instructed by E2E Label Help. Gator will check the results next cycle. The Review Readiness workflow also needs a successful reviewer-request reconciliation before handoff.
Gator metadata
- Validation: Focused policy-enforcement fix from a verified repository administrator; no duplicate found in targeted open searches.
- Blocking findings: None.
- Carried findings: None.
- Docs: Fern network policy documentation and policy-generation skill updated; no navigation change needed.
- Checks: Branch Checks, Helm Lint, Trivy Changes, DCO, and Vouch passed. Review Readiness previously failed during reviewer-request reconciliation; label-triggered reconciliation is being checked.
- E2E:
test:e2eapplied; current-head Branch E2E Checks run 41901845703 rerun accepted and queued. Earlier skipped E2E is not treated as runtime verification. - Head SHA:
1797fb917ff06bb145196701b66b4a9ea001b90e - Base SHA:
dbc0517a3103a1361194262a70800cf30c8fc939 - Merge base SHA:
dbc0517a3103a1361194262a70800cf30c8fc939 - Patch ID:
7ffe5c51c19d1cbb2c19424ee1bb31e9c8e74a0e - Gator payload:
13 - Review mode:
initial - Previous reviewed SHA: None.
- Review budget exhausted: No.
- Maintainer decision required: No.
- Next state:
gator:watch-pipeline
1797fb9 to
dfb0605
Compare
Maintainer Approval NeededGator's prior independent review remains applicable: the current head has the same effective patch, with no open Gator findings. Current-head Branch Checks, Helm Lint, Trivy Changes, DCO, and the standard E2E suite have passed. The requested maintainer reviewer is assigned. Action required: A maintainer must review and approve this PR. Gator metadata
|
Maintainer Review NudgeThis PR has been in @NVIDIA/openshell-maintainers @alangou, can someone review and either approve, request changes, or close this out? |
1 similar comment
Maintainer Review NudgeThis PR has been in @NVIDIA/openshell-maintainers @alangou, can someone review and either approve, request changes, or close this out? |
Maintainer Review NudgeThis PR has been in @NVIDIA/openshell-maintainers @alangou, can someone review and either approve, request changes, or close this out? |
Signed-off-by: John Myers <[email protected]>
dfb0605 to
3a0b9c2
Compare
BlockedThe existing independent review still applies: this head has the same effective patch, with no open Gator findings. Required E2E failed in Kubernetes HA conformance: Action required: A maintainer must retry the failed jobs in Branch E2E Checks and investigate sandbox cleanup if it repeats. Gator attempted the retry, but sandbox policy denied workflow reruns and no new attempt was queued. Gator metadata
|
Monitoring CompleteMonitoring is complete because this PR has merged. The last active Gator state was The active Gator metadata
|
Use the same route-selected protocol for request inspection and authorization. Preserve additive allow rules within that protocol, deny precedence, and credential ownership checks.
Share endpoint path selection across runtime and policy evaluation. Add regression coverage for overlapping routes, RPC/MCP requests, and credential admission. Update documentation and policy-generation guidance.
Validation: