Skip to content

feat(skills): extract issue and PR labeling - #5355

Merged
purp merged 26 commits into
NVIDIA:mainfrom
purp:feat/5276-extract-label-issue/purp
Nov 12, 2026
Merged

purp merged 26 commits into
NVIDIA:mainfrom
purp:feat/5276-extract-label-issue/purp

Conversation

@purp

@purp purp commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Extract /label-issue and a shared helper to classify accepted issues and PRs. Correct legacy, malformed, inaccurate and incomplete area/topic labels while preserving unrelated labels and human dispositions.

Related Issue

Closes #5353. Delivers Part 2 of #5276.

Changes

  • Classify from relevant expandable evidence: exactly one area and all supported topics. Existing labels describe state, not subject evidence; ambiguity stays local and the labeler posts no comments.
  • Share reconciliation with triage, preserving assessment judgment, triage comments and caller-specific confirmations.
  • Identify stale closures from the current stale label and matching bot closure metadata, without depending on comment wording or day counts.
  • Preview exact requests and verify additions before removals. Native checkpoints support model-free unchanged skips and partial-failure recovery. Fingerprints bind substantive content, identities, authority and taxonomy, ignoring reaction/profile/color noise while retaining raw evidence.

Supports POSIX with one coordinated executor per item; local locking provides neither cross-host serialization nor atomic GitHub writes. Dispatch and provider runtime belong to Part 3.

Live previews report missing canonical topic:dx; no-addition checkpoint paths require approved meta:labeler-checkpoint. This PR provisions neither label and applies no backlog changes.

Release Notes

Testing

  • 257 focused Python tests and 19 JavaScript acceptance tests.
  • Python syntax, skill metadata, JSON example, 48 local links/anchors, CLI help, and diff checks.
  • Ruff 0.14.14 formatting/lint across all 64 Python paths; ty 0.0.94 checks for all 12 labeling scripts.
  • Python CI: formatting, lint, full typecheck, SDK and helper tests pass on amd64 and arm64.
  • Markdownlint and Mermaid validation pass in the Markdown CI job.
  • Manual external skill discovery (npx -y skills add . --list): blocked by EACCES connecting to registry.npmjs.org; the check does not execute.

Checklist

  • Conventional Commits and DCO signoffs
  • Contributor guidance updated

@copy-pr-bot

copy-pr-bot Bot commented Nov 7, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@purp
purp force-pushed the feat/5276-extract-label-issue/purp branch from be7a82c to 5498be4 Compare November 11, 2026 14:32
@purp
purp changed the base branch from main to codex/base-5260 November 11, 2026 14:33
@purp
purp marked this pull request as ready for review November 11, 2026 15:43
@purp
purp requested review from a team, derekwaynecarr, mrunalp and sjenning as code owners November 11, 2026 15:43
@purp purp added the state:accepted A maintainer decided OpenShell should pursue this issue label Nov 11, 2026
@purp
purp force-pushed the feat/5276-extract-label-issue/purp branch from 8e8fadd to 6c3bf15 Compare November 11, 2026 17:17
purp added 15 commits November 11, 2026 21:43
@purp
purp force-pushed the feat/5276-extract-label-issue/purp branch from 6c31662 to 29b4687 Compare November 11, 2026 21:44
@purp
purp changed the base branch from codex/base-5260 to main November 11, 2026 21:44
@purp purp added the area:build CI/CD workflows, releases, build targets, packaging, and artifact publication. label Nov 12, 2026
@purp

purp commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator Author

/ok to test 29b4687

@purp
purp added this pull request to the merge queue Nov 12, 2026
Merged via the queue into NVIDIA:main with commit bde0ebc Nov 12, 2026
87 of 88 checks passed
@purp
purp deleted the feat/5276-extract-label-issue/purp branch November 12, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:build CI/CD workflows, releases, build targets, packaging, and artifact publication. state:accepted A maintainer decided OpenShell should pursue this issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: extract shared issue and PR labeling skill

2 participants