Skip to content

fix(deps): update russh to 0.65.1 - #5601

Merged
alangou merged 1 commit into
mainfrom
fix/dependency-refresh-20261116/alangou
Nov 16, 2026
Merged

alangou merged 1 commit into
mainfrom
fix/dependency-refresh-20261116/alangou

Conversation

@alangou

@alangou alangou commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Update the root SSH dependency from russh 0.65.0 to 0.65.1 for GHSA-9264-jvgf-6w2f and GHSA-736f-c93q-9fwx. The patched release verifies the server host key before the shared-secret callback and rechecks agent lock state after confirmation.

Related Issue

N/A. No issue, per user instruction.

Changes

  • Update russh in root Cargo.lock and drop the generic-array compatibility edge that the release no longer enables.
  • Keep the change in one lockfile-scoped, signed-off commit. No application source changes are required.

The affected consumers are the gateway SSH client and supervisor SSH server. The upstream patch release is compatible with the current manifests and pinned toolchain.

Both existing deny.toml exceptions were reassessed on 2026-11-16 and remain unchanged:

  • RUSTSEC-2023-0071: russh 0.65.1 still pins rsa 0.10.0-rc.18. Patched rsa 0.10.0 also conflicts when selected only for the server fixtures. Remove the exception when released SSH parents accept patched RSA and all runtime and fixture occurrences are validated.
  • RUSTSEC-2026-0459: released sqlx-sqlite 0.9.0 requires libsqlite3-sys <0.38.0; the patched range starts at 0.39.0. The upstream bound update is merged but unreleased. Remove the exception after a compatible SQLx release and validation across covered workspaces.

These two advisories remain unresolved. No exception was added or removed.

Release Notes

Testing

  • Full root mise run rust:deny, including crypto-policy regression checks, passes. Baseline advisory scans cover all 12 Cargo workspaces; diagnostic scans confirm the retained exceptions remain necessary.

  • mise run rust:lockfiles:check, mise run rust:format:check, mise run rust:check, and cargo clippy --locked --workspace --all-targets -- -D warnings pass.

  • mise run test:rust passes. This includes 141 supervisor-process tests with 71 SSH cases and 2,682 server tests; repository-defined ignored tests remain unchanged. The local PATH includes the installed e2fsprogs tools under /usr/sbin.

  • Local Docker E2E passes on the committed revision using images built from that tree: 36 conformance tests, 11 sandbox lifecycle tests, and the SSH host identity test across sandbox and gateway restarts.

  • Branch Checks passed on attempt 1 for fec86a3d2209e48d7bc90357ad3a534c4fd7ca65, including Linux and macOS Rust tests and lint.

  • Branch E2E Checks passed on attempt 1 for the same commit after exact-SHA admission, with test:e2e applied. All 99 selected jobs succeeded, including the Core E2E result. Coverage includes Docker, Podman, VM, Kubernetes, and packaged conformance, feature, and driver suites. The current-head OpenShell / Branch Checks and OpenShell / E2E gates both pass.

  • Local checks appropriate to the affected code and behavior pass

  • Unit tests added/updated (not applicable; existing tests exercise the lockfile update)

  • E2E tests added/updated (not applicable; existing suites are used)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (not applicable)

Update the root Cargo.lock resolution for GHSA-9264-jvgf-6w2f and
GHSA-736f-c93q-9fwx. The patched release verifies the server host key before
calling kex_done and rechecks SSH agent lock state after confirmation.

Drop the generic-array compatibility edge no longer enabled by russh.

Signed-off-by: Adrien Langou <[email protected]>
@alangou alangou added the test:e2e Requires end-to-end coverage label Nov 16, 2026
@copy-pr-bot

copy-pr-bot Bot commented Nov 16, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the state:accepted A maintainer decided OpenShell should pursue this issue label Nov 16, 2026
@github-actions

Copy link
Copy Markdown

Label test:e2e applied, but pull-request/5601 does not exist yet. A maintainer needs to comment /ok to test fec86a3d2209e48d7bc90357ad3a534c4fd7ca65 to mirror this PR. Once the mirror exists, re-apply the label or re-run Branch E2E Checks from the Actions tab.

@alangou

alangou commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test fec86a3

@alangou
alangou added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit f1cf055 Nov 16, 2026
162 of 163 checks passed
@alangou
alangou deleted the fix/dependency-refresh-20261116/alangou branch November 16, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:accepted A maintainer decided OpenShell should pursue this issue test:e2e Requires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants