Skip to content

chore(deps): refresh blocked advisory exceptions - #5637

Merged
alangou merged 2 commits into
mainfrom
fix/dependency-remediation-20261117/alangou
Nov 17, 2026
Merged

alangou merged 2 commits into
mainfrom
fix/dependency-remediation-20261117/alangou

Conversation

@alangou

@alangou alangou commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Document the dependency advisories that remain blocked after reviewing current main. Add a temporary exception for unmaintained chrono and refresh the RSA exception to reflect its current crypto-policy blocker. These advisories remain unresolved.

Related Issue

N/A, no covering issue per the requested dependency-remediation workflow.

Changes

  • Add RUSTSEC-2026-0543 for chrono 0.4.45. There is no patched release; replacing direct time APIs and Kubernetes, OAuth2 and OCI dependency paths requires a coordinated migration. Remove after all covered graphs migrate and pass validation. Upstream maintenance notice.
  • Update RUSTSEC-2023-0071. russh 0.65.2 now accepts patched rsa 0.10.0, but RSA's mandatory HMAC dependency introduces a parent not allowed by the current crypto policy. Retain the exception until that policy change is reviewed and authorized, then upgrade and validate SSH and OIDC fixture consumers. RSA dependency manifest.
  • Retain RUSTSEC-2026-0459 after reassessment. Published SQLx 0.9.0 still requires libsqlite3-sys <0.38.0, excluding the patched floor of 0.39.0. Remove after a compatible SQLx release and validation across covered graphs. Merged, unreleased upstream fix.

The two commits are dependency-scoped and change only deny.toml. Dependency versions and executable inputs remain unchanged. No advisory exception is presented as a vulnerability fix.

The deferred RSA upgrade also requires adapting OIDC test fixtures to RSA 0.10. Those source changes remain outside this PR, and their runtime validation is incomplete.

Testing

Validated against main 0be63c5b0de27692df03ba0e4b3bc212312d3b3c and delivery head f7f1c30e37b52bcc8baca7a586a72f92a4ee371e:

  • Full mise run rust:deny, including all nine crypto-policy regression fixtures. Advisory, ban, license and source checks pass with the disclosed exceptions.
  • mise run rust:lockfiles:check, covering all 12 tracked Cargo lockfiles and five aligned sibling workspaces.
  • Locked advisory scans for all 12 Cargo workspaces with normal RustSec refresh; scans left lockfile hashes unchanged.
  • git diff --check and clean tracked tree.
  • Unit/runtime suites are not applicable to this exception-only diff.
  • Remote CI and E2E results. test:e2e is requested for this PR revision.

Current-head Branch E2E Checks attempt 3 completed with two sandbox-deletion timeouts in k3s-ha: file_transfer::upload_download_round_trip and settings::sandbox_setting_round_trip. The result jobs failed downstream. Kubernetes and Podman builds passed after the earlier Cachix incident. The HA stall is already tracked in #5520; its cause is not established for this run. Runtime source, tests, manifests and lockfiles remain unchanged from the pinned baseline.

Branch Checks, Helm Lint and Trivy Changes passed. SDAChess approved the current head. Automatic Review Readiness remains blocked by the reviewer-roster problem tracked in #5549. The Chrono/RSA implementation follow-up is tracked in #5642.

Checklist

  • Follows Conventional Commits.
  • Commits are signed off for DCO.
  • Architecture documentation changes are not applicable.

Record RUSTSEC-2026-0543 for chrono 0.4.45. No patched release exists; replacing direct time APIs and transitive Kubernetes, OAuth2, and OCI consumers requires a coordinated migration. Keep all other cargo-deny policies unchanged.

Signed-off-by: Adrien Langou <[email protected]>
russh 0.65.2 now accepts patched rsa 0.10.0, but rsa adds a mandatory hmac dependency outside the current wrapper policy. Retain RUSTSEC-2023-0071 until that policy change is reviewed and authorized, then upgrade and validate SSH and OIDC test-fixture consumers.

Signed-off-by: Adrien Langou <[email protected]>
@alangou alangou added topic:security Vulnerability management, security analysis/auditing, bypass detection, and abuse prevention. test:e2e Requires end-to-end coverage area:build CI/CD workflows, releases, build targets, packaging, and artifact publication. labels Nov 17, 2026
@copy-pr-bot

copy-pr-bot Bot commented Nov 17, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

Copy link
Copy Markdown

Label test:e2e applied, but pull-request/5637 does not exist yet. A maintainer needs to comment /ok to test f7f1c30e37b52bcc8baca7a586a72f92a4ee371e to mirror this PR. Once the mirror exists, re-apply the label or re-run Branch E2E Checks from the Actions tab.

@github-actions github-actions Bot added the state:accepted A maintainer decided OpenShell should pursue this issue label Nov 17, 2026
@alangou

alangou commented Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test f7f1c30

@alangou
alangou requested a review from SDAChess November 17, 2026 11:54
@alangou
alangou enabled auto-merge November 17, 2026 12:40
@alangou
alangou disabled auto-merge November 17, 2026 12:41
@alangou
alangou merged commit ce58cf8 into main Nov 17, 2026
440 of 454 checks passed
@alangou
alangou deleted the fix/dependency-remediation-20261117/alangou branch November 17, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:build CI/CD workflows, releases, build targets, packaging, and artifact publication. state:accepted A maintainer decided OpenShell should pursue this issue test:e2e Requires end-to-end coverage topic:security Vulnerability management, security analysis/auditing, bypass detection, and abuse prevention.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants