Repository navigation
feat(sdk): retry sandbox create on MUTATION_LOCK_TIMEOUT - #5725
Open
ericcurtin wants to merge 1 commit into
Open
ericcurtin wants to merge 1 commit into
ericcurtin wants to merge 1 commit into
Conversation
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
Contributor
Author
Collaborator
|
@ericcurtin @EmilienM , won't it be better to have this retry in other SDKs too ?, Python, Typescript etc, to have a consistent behaviour |
Contributor
|
I was also working on this issue, I'll post the PR. Happy to close mine and keep yours. |
Collaborator
|
@EmilienM , we can take this PR for Rust & CLI, and can we repurpose this PR to fix for other SDKs if its okay |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retry sandbox create in the Rust SDK and CLI when the gateway reports
MUTATION_LOCK_TIMEOUT.Related Issue
Closes #5697
Changes
RetryPolicyandretry_create(server delay floor, jitter, time budget).SdkError::is_lock_contention,retryable(),with_create_retry.--create-retry-timeout,--no-create-retry.ErrorInfo/RetryInfo; a name held by aDeletingsandbox returnsSANDBOX_DELETING, which clients wait out only after a failed attempt.Release Notes
openshell sandbox createand the Rust SDK now retry for up to 60s when the gateway is busy.Testing
Ran clippy and tests for
openshell-core,openshell-sdk,openshell-cliand the servercomputetests.Checklist