Repository navigation
ui: fix and block configuration of global settings at a scoped settings page - #14710
Open
winterhazel wants to merge 1 commit into
Open
winterhazel wants to merge 1 commit into
winterhazel wants to merge 1 commit into
Conversation
Member
Author
|
@winterhazel a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.22 #14710 +/- ##
============================================
- Coverage 18.32% 18.32% -0.01%
Complexity 16644 16644
============================================
Files 5939 5939
Lines 537787 537798 +11
Branches 65932 65932
============================================
- Hits 98544 98542 -2
- Misses 428033 428045 +12
- Partials 11210 11211 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
UI build: ✔️ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two ways in which scoped configuration pages could accidentally update settings at the global level.
When accessing an account's page by clicking the
Accountcolumn in a list, the page opens without the account ID in the URL. Because of this, anyupdateConfigurationexecuted on the page is sent without theaccountid, allowing operators to accidentally update settings at the global level.In addition, the graphical interface also allows operators to update settings at a Management Server level; however, the ID of the selected Management Server was never provided to the API, which caused the settings to be changed globally as well.
These issues have been fixed.
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
How Has This Been Tested?
Accountcolumn of a list and confirmed that a setting update is sent with theaccountidand only affects that account, without changing the global value.managementserveridand only affect the selected Management Server.