Skip to content

ui: fix and block configuration of global settings at a scoped settings page - #14710

Open
winterhazel wants to merge 1 commit into
apache:4.22from
winterhazel:fix-ui-setting-update
Open

winterhazel wants to merge 1 commit into
apache:4.22from
winterhazel:fix-ui-setting-update

Conversation

@winterhazel

Copy link
Copy Markdown
Member

Description

This PR fixes two ways in which scoped configuration pages could accidentally update settings at the global level.

When accessing an account's page by clicking the Account column in a list, the page opens without the account ID in the URL. Because of this, any updateConfiguration executed on the page is sent without the accountid, allowing operators to accidentally update settings at the global level.

In addition, the graphical interface also allows operators to update settings at a Management Server level; however, the ID of the selected Management Server was never provided to the API, which caused the settings to be changed globally as well.

These issues have been fixed.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

  • Opened an account's settings page from the Account column of a list and confirmed that a setting update is sent with the accountid and only affects that account, without changing the global value.
  • Opened a Management Server's settings page and confirmed that updates/resets are sent with the managementserverid and only affect the selected Management Server.

@winterhazel winterhazel changed the title ui: fix and block configuration of global settings at a scoped settin… ui: fix and block configuration of global settings at a scoped settings page Nov 16, 2026
@winterhazel

Copy link
Copy Markdown
Member Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@winterhazel a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov

codecov Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.32%. Comparing base (b56bbc2) to head (a8d016f).

Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #14710      +/-   ##
============================================
- Coverage     18.32%   18.32%   -0.01%     
  Complexity    16644    16644              
============================================
  Files          5939     5939              
  Lines        537787   537798      +11     
  Branches      65932    65932              
============================================
- Hits          98544    98542       -2     
- Misses       428033   428045      +12     
- Partials      11210    11211       +1     
Flag Coverage Δ
uitests 4.08% <ø> (-0.01%) ⬇️
unittests 19.41% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/14710 (QA-JID-1018)

@winterhazel winterhazel added the Severity:Critical Critical bug label Nov 16, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants