Skip to content

kboss: consider kboss.timeout at zone level - #14711

Open
winterhazel wants to merge 1 commit into
apache:mainfrom
winterhazel:kboss-timeout-zone-level
Open

winterhazel wants to merge 1 commit into
apache:mainfrom
winterhazel:kboss-timeout-zone-level

Conversation

@winterhazel

Copy link
Copy Markdown
Member

Description

Currently, the kboss.timeout setting can be configured at a zone level; however, the code always uses the value configured globally.

The code was adjusted to also consider the value configured at zone level. The timeout is now resolved from the zone of the host that will execute the KBOSS command. If the host cannot be found, the global value is used as a fallback.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

  • I configured kboss.timeout for a zone and validated that backups of VMs from that zone were using the zone level value instead of the global value.

@winterhazel

Copy link
Copy Markdown
Member Author

@blueorangutan package

@winterhazel winterhazel changed the title kboss: consider kboss.timeout at zone-level kboss: consider kboss.timeout at zone level Nov 16, 2026
@blueorangutan

Copy link
Copy Markdown

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@codecov

codecov Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.78%. Comparing base (278bde2) to head (159becf).

Files with missing lines Patch % Lines
.../apache/cloudstack/backup/KbossBackupProvider.java 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #14711   +/-   ##
=========================================
  Coverage     20.78%   20.78%           
- Complexity    20857    20859    +2     
=========================================
  Files          6053     6053           
  Lines        548230   548238    +8     
  Branches      73237    73239    +2     
=========================================
+ Hits         113928   113934    +6     
- Misses       420955   420957    +2     
  Partials      13347    13347           
Flag Coverage Δ
uitests 3.86% <ø> (ø)
unittests 22.21% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 20074

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants