Repository navigation
Conversation
The docs site is served from a subdirectory (https://github.github.io/catalyst/), but the vendored primer.css referenced the Inter font files with root-absolute URLs (url("/fonts/Inter-*.woff")), so browsers requested them from the domain root where they do not exist and fell back to system fonts. Use relative URLs (url("fonts/Inter-*.woff")) instead: primer.css is served from the same directory as the fonts/ folder, so the fonts resolve under the site's base path. Fixes github#109
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain, and the change consistently updates all Inter font references to stylesheet-relative paths while preserving the existing font files and loading configuration.
Copilot wasn't able to review any files in this pull request.
1 file not reviewed
docs/primer.css: Generated file
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! This fixes #109.
Problem: the docs site is served from a subdirectory (
https://github.github.io/catalyst/), but the vendoreddocs/primer.cssreferenced the Inter font files with root-absolute URLs (url("/fonts/Inter-*.woff")). Browsers therefore requested them from the domain root, where they don't exist, so the site fell back to system fonts even though the font files are shipped indocs/fonts/.Fix: changed all 12 font URLs in
docs/primer.cssto relative paths (url("fonts/Inter-*.woff")). Sinceprimer.cssis served from the same directory as thefonts/folder, the fonts now resolve under the site's base path. The stylesheets themselves are already linked with{{ site.baseurl }}in_layouts/default.html, so only the URLs inside the CSS needed this change.I couldn't run the Jekyll site build locally in this environment, so the fix is verified by inspection: the font files exist at
docs/fonts/Inter-{Regular,Medium,Bold}.woffand the relative URLs resolve against the served location ofprimer.css.Fixes #109