Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain, and the change is narrowly focused on expanding descriptor behavior coverage across the documented cases.
No open issues 🎉
What changed in this PR
Adds browser tests for getPropertyDescriptor, covering own properties, inherited descriptors, accessors, symbol keys, and missing properties.
Changes:
- Tests complete descriptors for own data properties.
- Covers prototype-chain lookup, getter descriptors, and symbol keys.
- Verifies missing keys return
undefinedwhile inheritedObject.prototypeproperties are found.
| File | Description |
|---|---|
| test/get-property-descriptor.ts | Adds comprehensive tests for getPropertyDescriptor across own properties, prototype-chain descriptors, accessors, symbols, and missing keys. |
Review effort: Lite (adaptive)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi team, thank you for this wonderful project! I noticed that
getPropertyDescriptor(used bymark.tsto read accessors) has no test coverage, so I added a small test file for it:undefinedfor a missing key (and found onObject.prototype, e.g.toString)I verified the assertions against the current implementation in Node (all 5 groups pass), and
tsc --noEmitandeslintare both clean. I could not run the fullnpm testsuite locally because this machine has no usable Chrome for web-test-runner, so I would appreciate CI running the browser tests. Please let me know if anything needs adjusting!