Skip to content

Also track increasing type IDs for base constraint walks - #65555

Open
Jake Bailey (jakebailey) wants to merge 2 commits into
microsoft:mainfrom
jakebailey:base-constraint-indexed-access-chains
Open

Jake Bailey (jakebailey) wants to merge 2 commits into
microsoft:mainfrom
jakebailey:base-constraint-indexed-access-chains

Conversation

@jakebailey

Copy link
Copy Markdown
Member

This fix was pulled out of #65064 and reworked to work on main without the "type generation" thing.

#65520 sort of fixes this but not really, it just hides the one specific case and not the root cause.


When the checker computes a base constraint, it walks the chain of nested constraints with a stack of the recursion identities it has passed through. Past ten levels, it stops as soon as a type's recursion identity is already on the stack, since an expanding instantiation like Foo<T> → Foo<Foo<T>> → … could otherwise go on forever.

This goes wrong for a chain of indexed accesses like T["a"]["a"]…["a"]. Each level's object type has the recursion identity of T, so a chain of ten or more stops the walk, even though it is finite. The base constraint is lost, and property accesses on the chain, and even on T itself, report false TS2339 errors. Base constraints already resolved aren't walked again, so whether the walk hits the limit depends on which declaration happens to be checked first.

To fix this, each stack frame also records the type's id, and a type only counts as a repeat if its id is at least that of the matching frame. Type ids are assigned in creation order, as isDeeplyNestedType already assumes. Each step of an expanding instantiation is created from the step before it, so it always has a higher id and still stops the walk. The object type of an indexed access is part of the access and was created before it, so its id is lower, and walking into it never counts as a repeat.

Fixes #65508
Closes #65520

A chain of ten indexed accesses reaching the same type parameter is
finite, but its base constraint is lost depending on which declaration
is checked first, and accessing a property of it, or of the type
parameter itself, reports a false error.

For 65508
Computing a base constraint gives up past ten levels of nesting once a
type with the same recursion identity repeats, as a repeating pattern
could be instantiated without end. The object types of a chain of
indexed accesses, such as T["a"]["a"]["a"], all share the identity of
T, so a chain of ten or more gave up, and accessing a property of it
failed. Base constraints already resolved are not walked again, so
whether a walk reached the limit depended on which declaration was
checked first.

A type repeats only if it is no older than the type with the same
identity on the stack, as each step of an expanding instantiation is
built from the step before it, whereas the object type of an indexed
access is a part of it. As in isDeeplyNestedType, type ids give the
order in which types were created.

Fixes 65508
Copilot AI balanced review requested due to automatic review settings November 17, 2026 21:23
@github-project-automation github-project-automation Bot moved this to Not started in PR Backlog Nov 17, 2026
@typescript-automation typescript-automation Bot added Author: Team For Backlog Bug PRs that fix a backlog bug labels Nov 17, 2026
@jakebailey

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) test it

@typescript-automation

typescript-automation Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started ✅ Results
user test this ✅ Started ✅ Results
run dt ✅ Started ✅ Results
perf test this faster ✅ Started 👀 Results

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the update to the Go checker’s base-constraint recursion guard.

No open issues 🎉

What changed in this PR

Updates the Go checker’s base-constraint recursion guard to distinguish finite indexed-access chains from expanding instantiations, addressing the false property errors reported in #65508.

Changes:

  • Tracks type IDs alongside recursion identities so walks into older component types can continue.
  • Adds a regression test covering ten-level indexed-access chains and declaration-order-sensitive constraint resolution.
  • Adds type and symbol baselines confirming the expected property types and bindings.
File Description
tsc/​testdata/​tests/​cases/​compiler/​deepIndexedAccessChainConstraint.ts Tests constraint preservation through deep indexed-access chains.
tsc/​testdata/​baselines/​reference/​compiler/​deepIndexedAccessChainConstraint.types Records expected types, including string property results.
tsc/​testdata/​baselines/​reference/​compiler/​deepIndexedAccessChainConstraint.symbols Records expected symbol bindings for the regression test.
tsc/​internal/​checker/​checker.go Makes base-constraint repeat detection account for type-ID ordering.

Review effort: Balanced

@typescript-automation

Copy link
Copy Markdown
Contributor

Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

@typescript-automation

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey) Here are the results of running the user tests with tsc comparing baseline and pr:

Everything looks good!

@typescript-automation

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - native
Errors 41 41 ~ ~ ~ p=1.000 n=40
Symbols 88,381 88,381 ~ ~ ~ p=1.000 n=40
Types 79,508 79,508 ~ ~ ~ p=1.000 n=40
Memory Used 106,367k (± 0.02%) 106,396k (± 0.02%) ~ 106,260k 106,517k p=0.154 n=40
Memory Allocs 1,060,040 (± 0.01%) 1,060,176 (± 0.00%) +136 (+ 0.01%) 1,059,772 1,060,626 p=0.001 n=40
Config Time 0.000s 0.000s ~ ~ ~ p=1.000 n=40
Parse Time 0.022s (± 1.51%) 0.022s (± 1.75%) ~ 0.019s 0.024s p=0.434 n=40
Bind Time 0.008s (± 3.35%) 0.008s (± 3.38%) ~ 0.007s 0.010s p=0.512 n=40
Check Time 0.204s (± 0.70%) 0.204s (± 0.72%) ~ 0.195s 0.218s p=0.588 n=40
Emit Time 0.131s (± 0.62%) 0.131s (± 0.73%) ~ 0.128s 0.141s p=0.776 n=40
Total Time 0.368s (± 0.51%) 0.369s (± 0.56%) ~ 0.357s 0.390s p=0.536 n=40
angular-1 - native
Errors 63 63 ~ ~ ~ p=1.000 n=40
Symbols 754,008 754,008 ~ ~ ~ p=1.000 n=40
Types 548,695 548,695 ~ ~ ~ p=1.000 n=40
Memory Used 643,245k (± 0.01%) 643,106k (± 0.01%) -141k (- 0.02%) 642,515k 643,568k p=0.005 n=40
Memory Allocs 8,338,583 (± 0.12%) 8,336,126 (± 0.07%) ~ 8,326,696 8,446,390 p=0.094 n=40
Config Time 0.007s (± 2.50%) 0.007s (± 2.57%) ~ 0.006s 0.008s p=0.588 n=40
Parse Time 0.118s (± 2.07%) 0.117s (± 2.78%) ~ 0.103s 0.156s p=0.280 n=40
Bind Time 0.039s (± 5.85%) 0.042s (± 6.59%) ~ 0.034s 0.064s p=0.084 n=40
Check Time 0.620s (± 0.97%) 0.618s (± 1.37%) ~ 0.583s 0.719s p=0.408 n=40
Emit Time 0.388s (± 0.89%) 0.391s (± 0.97%) ~ 0.376s 0.431s p=0.207 n=40
Total Time 1.184s (± 0.84%) 1.189s (± 1.10%) ~ 1.144s 1.346s p=0.940 n=40
arktype - native
Errors 0 0 ~ ~ ~ p=1.000 n=40
Symbols 676,938 676,940 +2 (+ 0.00%) ~ ~ p=0.000 n=40
Types 937,070 937,080 +10 (+ 0.00%) ~ ~ p=0.000 n=40
Memory Used 473,690k (± 0.01%) 473,685k (± 0.01%) ~ 473,487k 473,877k p=0.795 n=40
Memory Allocs 11,820,825 (± 0.02%) 11,836,466 (± 0.02%) +16,436 (+ 0.14%) 11,831,886 11,864,215 p=0.000 n=40
Config Time 0.001s 0.001s ~ ~ ~ p=1.000 n=40
Parse Time 0.040s (± 2.50%) 0.040s (± 2.46%) ~ 0.035s 0.048s p=0.312 n=40
Bind Time 0.012s (± 6.09%) 0.012s (± 4.24%) ~ 0.010s 0.017s p=0.795 n=40
Check Time 0.811s (± 0.36%) 0.814s (± 0.70%) ~ 0.788s 0.914s p=0.553 n=40
Emit Time 0.000s 0.000s ~ ~ ~ p=1.000 n=40
Total Time 0.891s (± 0.26%) 0.893s (± 0.64%) ~ 0.869s 0.993s p=0.946 n=40
class-transformer - native
Errors 0 0 ~ ~ ~ p=1.000 n=40
Symbols 45,376 45,376 ~ ~ ~ p=1.000 n=40
Types 7,573 7,573 ~ ~ ~ p=1.000 n=40
Memory Used 27,744k (± 0.02%) 27,744k (± 0.02%) ~ 27,714k 27,774k p=0.732 n=40
Memory Allocs 232,098 (± 0.03%) 232,444 (± 0.03%) +325 (+ 0.14%) 231,979 233,048 p=0.000 n=40
Config Time 0.001s 0.001s ~ ~ ~ p=1.000 n=40
Parse Time 0.011s (± 3.24%) 0.012s (± 2.87%) ~ 0.009s 0.014s p=0.374 n=40
Bind Time 0.003s (± 7.01%) 0.003s (± 7.50%) ~ 0.002s 0.005s p=0.390 n=40
Check Time 0.008s (± 4.59%) 0.008s (± 4.39%) ~ 0.006s 0.010s p=0.665 n=40
Emit Time 0.007s (± 4.72%) 0.007s (± 5.61%) ~ 0.006s 0.010s p=0.240 n=40
Total Time 0.031s (± 1.79%) 0.031s (± 1.98%) ~ 0.025s 0.035s p=0.285 n=40
effect - native
Errors 12 12 ~ ~ ~ p=1.000 n=40
Symbols 1,234,359 1,234,359 ~ ~ ~ p=1.000 n=40
Types 893,315 893,315 ~ ~ ~ p=1.000 n=40
Memory Used 941,067k (± 0.01%) 941,131k (± 0.02%) ~ 940,281k 942,409k p=0.675 n=40
Memory Allocs 11,755,824 (± 0.04%) 11,773,613 (± 0.03%) +19,158 (+ 0.16%) 11,755,425 11,805,764 p=0.000 n=40
Config Time 0.002s (± 4.06%) 0.002s (± 6.71%) ~ 0.002s 0.005s p=0.572 n=40
Parse Time 0.152s (± 1.65%) 0.154s (± 2.53%) ~ 0.134s 0.220s p=0.602 n=40
Bind Time 0.000s 0.000s ~ ~ ~ p=1.000 n=40
Check Time 0.889s (± 1.11%) 0.887s (± 0.97%) ~ 0.805s 0.935s p=0.427 n=40
Emit Time 0.482s (± 1.73%) 0.486s (± 1.56%) ~ 0.429s 0.550s p=0.440 n=40
Total Time 1.618s (± 0.93%) 1.624s (± 0.96%) ~ 1.498s 1.765s p=0.900 n=40
mui-docs - native
Errors 11,405 11,405 ~ ~ ~ p=1.000 n=40
Symbols 3,730,768 3,730,768 ~ ~ ~ p=1.000 n=40
Types 1,354,170 1,354,170 ~ ~ ~ p=1.000 n=40
Memory Used 1,667,045k (± 0.05%) 1,667,206k (± 0.06%) ~ 1,661,913k 1,673,146k p=0.837 n=40
Memory Allocs 25,153,913 (± 0.05%) 25,156,841 (± 0.05%) ~ 25,070,466 25,312,393 p=0.656 n=40
Config Time 0.006s (± 2.13%) 0.006s (± 2.14%) ~ 0.006s 0.007s p=0.375 n=40
Parse Time 0.277s (± 2.05%) 0.277s (± 1.56%) ~ 0.244s 0.308s p=0.983 n=40
Bind Time 0.001s (±13.35%) 0.001s (±12.62%) ~ 0.001s 0.004s p=0.608 n=40
Check Time 2.916s (± 0.98%) 2.897s (± 1.00%) ~ 2.706s 3.173s p=0.154 n=40
Emit Time 0.256s (± 1.29%) 0.257s (± 2.37%) ~ 0.239s 0.359s p=0.588 n=40
Total Time 3.962s (± 0.98%) 3.937s (± 0.88%) ~ 3.708s 4.278s p=0.289 n=40
sentry - native
Errors 2 2 ~ ~ ~ p=1.000 n=40
Symbols 4,782,801 4,782,801 ~ ~ ~ p=1.000 n=40
Types 2,605,444 2,605,444 ~ ~ ~ p=1.000 n=40
Memory Used 2,798,281k (± 0.02%) 2,799,169k (± 0.02%) ~ 2,795,736k 2,805,153k p=0.066 n=40
Memory Allocs 74,620,562 (± 0.05%) 74,671,759 (± 0.06%) ~ 74,446,413 75,313,544 p=0.271 n=40
Config Time 0.018s (± 2.87%) 0.018s (± 2.82%) ~ 0.016s 0.022s p=0.739 n=40
Parse Time 0.476s (± 3.50%) 0.469s (± 3.01%) ~ 0.392s 0.600s p=0.952 n=40
Bind Time 0.149s (± 6.55%) 0.145s (± 5.81%) ~ 0.127s 0.223s p=0.506 n=40
Check Time 6.650s (± 1.35%) 6.676s (± 1.35%) ~ 6.233s 7.452s p=0.100 n=40
Emit Time 0.000s 0.000s ~ ~ ~ p=1.000 n=40
Total Time 7.345s (± 1.34%) 7.357s (± 1.37%) ~ 6.873s 8.196s p=0.468 n=40
social-app - native
Errors 0 0 ~ ~ ~ p=1.000 n=40
Symbols 1,872,618 1,872,618 ~ ~ ~ p=1.000 n=40
Types 1,150,836 1,150,836 ~ ~ ~ p=1.000 n=40
Memory Used 948,722k (± 0.01%) 948,696k (± 0.01%) ~ 947,891k 949,717k p=0.715 n=40
Memory Allocs 13,419,994 (± 0.10%) 13,442,130 (± 0.09%) +26,251 (+ 0.20%) 13,381,608 13,572,508 p=0.013 n=40
Config Time 0.006s (± 2.90%) 0.005s (± 2.43%) ~ 0.005s 0.006s p=0.464 n=40
Parse Time 0.153s (± 2.51%) 0.153s (± 2.14%) ~ 0.137s 0.181s p=0.928 n=40
Bind Time 0.041s (± 6.36%) 0.040s (± 6.37%) ~ 0.033s 0.065s p=0.526 n=40
Check Time 1.394s (± 0.80%) 1.400s (± 0.67%) ~ 1.356s 1.476s p=0.343 n=40
Emit Time 0.000s 0.000s ~ ~ ~ p=1.000 n=40
Total Time 1.614s (± 0.74%) 1.616s (± 0.64%) ~ 1.563s 1.712s p=0.920 n=40
strada-build-src - native
Errors 0 0 ~ ~ ~ p=1.000 n=40
Symbols 1,183,341 1,183,341 ~ ~ ~ p=1.000 n=40
Types 437,605 437,605 ~ ~ ~ p=1.000 n=40
Memory Used 1,154,656k (± 0.20%) 1,156,385k (± 0.24%) ~ 1,141,050k 1,179,057k p=0.368 n=40
Memory Allocs 40,062,171 (± 0.07%) 40,099,705 (± 0.06%) ~ 39,975,142 40,319,272 p=0.094 n=40
Config Time 0.002s (± 9.19%) 0.002s (± 9.99%) ~ 0.000s 0.003s p=0.876 n=40
Parse Time 0.133s (± 1.46%) 0.135s (± 1.54%) ~ 0.124s 0.156s p=0.301 n=40
Bind Time 0.000s 0.000s ~ ~ ~ p=1.000 n=40
Check Time 0.794s (± 0.43%) 0.798s (± 1.46%) ~ 0.754s 0.981s p=0.304 n=40
Emit Time 0.137s (± 1.88%) 0.137s (± 1.74%) ~ 0.127s 0.163s p=0.499 n=40
Total Time 9.238s (± 0.47%) 9.281s (± 1.51%) ~ 8.986s 11.837s p=0.420 n=40
strada-compiler - native
Errors 0 0 ~ ~ ~ p=1.000 n=40
Symbols 262,982 262,982 ~ ~ ~ p=1.000 n=40
Types 195,974 195,974 ~ ~ ~ p=1.000 n=40
Memory Used 221,415k (± 0.01%) 221,419k (± 0.01%) ~ 221,263k 221,576k p=0.942 n=40
Memory Allocs 1,911,578 (± 0.01%) 1,913,547 (± 0.01%) +1,939 (+ 0.10%) 1,911,375 1,914,798 p=0.000 n=40
Config Time 0.000s (±136.80%) 0.000s (±117.43%) ~ 0.000s 0.002s p=0.671 n=40
Parse Time 0.048s (± 2.01%) 0.049s (± 2.04%) ~ 0.042s 0.056s p=0.863 n=40
Bind Time 0.000s 0.000s ~ ~ ~ p=1.000 n=40
Check Time 0.370s (± 0.59%) 0.369s (± 0.66%) ~ 0.358s 0.405s p=0.664 n=40
Emit Time 0.046s (± 3.33%) 0.048s (± 5.47%) ~ 0.040s 0.090s p=0.269 n=40
Total Time 0.491s (± 0.69%) 0.494s (± 0.73%) ~ 0.481s 0.537s p=0.067 n=40
t3code-server - native
Errors 0 0 ~ ~ ~ p=1.000 n=40
Symbols 4,345,071 4,345,071 ~ ~ ~ p=1.000 n=40
Types 3,040,936 3,040,936 ~ ~ ~ p=1.000 n=40
Memory Used 2,393,847k (± 0.02%) 2,393,425k (± 0.01%) ~ 2,391,449k 2,396,278k p=0.347 n=40
Memory Allocs 37,040,963 (± 0.04%) 37,094,592 (± 0.05%) +53,662 (+ 0.14%) 37,027,844 37,295,659 p=0.000 n=40
Config Time 0.003s (± 5.24%) 0.003s (± 5.95%) 0.000s ( 0.00%) 0.002s 0.003s p=0.015 n=40
Parse Time 0.254s (± 2.27%) 0.252s (± 1.54%) ~ 0.222s 0.282s p=0.841 n=40
Bind Time 0.092s (± 6.38%) 0.095s (± 7.38%) ~ 0.074s 0.149s p=0.602 n=40
Check Time 5.985s (± 0.55%) 6.018s (± 0.65%) ~ 5.769s 6.349s p=0.390 n=40
Emit Time 0.000s 0.000s ~ ~ ~ p=1.000 n=40
Total Time 6.347s (± 0.54%) 6.380s (± 0.66%) ~ 6.128s 6.736s p=0.327 n=40
tanstack-router - native
Errors 1 1 ~ ~ ~ p=1.000 n=40
Symbols 568,576 568,580 +4 (+ 0.00%) ~ ~ p=0.000 n=40
Types 396,130 397,313 +1,183 (+ 0.30%) ~ ~ p=0.000 n=40
Memory Used 315,086k (± 0.01%) 315,257k (± 0.01%) +171k (+ 0.05%) 314,975k 315,494k p=0.000 n=40
Memory Allocs 4,166,240 (± 0.07%) 4,179,443 (± 0.15%) +10,016 (+ 0.24%) 4,166,186 4,291,575 p=0.000 n=40
Config Time 0.001s 0.001s ~ ~ ~ p=1.000 n=40
Parse Time 0.041s (± 2.45%) 0.040s (± 2.24%) ~ 0.035s 0.047s p=0.306 n=40
Bind Time 0.013s (± 7.31%) 0.013s (± 7.64%) ~ 0.010s 0.021s p=0.750 n=40
Check Time 0.460s (± 0.43%) 0.464s (± 0.58%) +0.003s (+ 0.76%) 0.447s 0.493s p=0.023 n=40
Emit Time 0.000s 0.000s ~ ~ ~ p=1.000 n=40
Total Time 0.532s (± 0.50%) 0.535s (± 0.58%) ~ 0.512s 0.562s p=0.116 n=40
ts-pre-modules - native
Errors 87 87 ~ ~ ~ p=1.000 n=40
Symbols 231,156 231,156 ~ ~ ~ p=1.000 n=40
Types 181,003 181,003 ~ ~ ~ p=1.000 n=40
Memory Used 190,763k (± 0.01%) 190,774k (± 0.01%) ~ 190,553k 190,921k p=0.397 n=40
Memory Allocs 1,307,040 (± 0.01%) 1,308,771 (± 0.01%) +1,688 (+ 0.13%) 1,307,991 1,310,037 p=0.000 n=40
Config Time 0.000s 0.000s ~ ~ ~ p=1.000 n=40
Parse Time 0.042s (± 2.75%) 0.043s (± 4.48%) ~ 0.038s 0.076s p=0.369 n=40
Bind Time 0.020s (± 4.41%) 0.021s (± 4.95%) ~ 0.016s 0.034s p=0.261 n=40
Check Time 0.293s (± 1.73%) 0.289s (± 1.00%) ~ 0.271s 0.314s p=0.386 n=40
Emit Time 0.000s 0.000s ~ ~ ~ p=1.000 n=40
Total Time 0.361s (± 1.60%) 0.360s (± 1.11%) ~ 0.343s 0.395s p=0.983 n=40
vscode - native
Errors 0 0 ~ ~ ~ p=1.000 n=40
Symbols 8,487,086 8,487,086 ~ ~ ~ p=1.000 n=40
Types 4,936,301 4,936,301 ~ ~ ~ p=1.000 n=40
Memory Used 5,674,626k (± 0.01%) 5,674,144k (± 0.01%) ~ 5,670,276k 5,680,144k p=0.221 n=40
Memory Allocs 63,170,057 (± 0.01%) 63,214,625 (± 0.01%) +42,184 (+ 0.07%) 63,187,521 63,310,213 p=0.000 n=40
Config Time 0.026s (± 4.05%) 0.027s (± 3.38%) ~ 0.022s 0.034s p=0.153 n=40
Parse Time 0.982s (± 2.13%) 0.992s (± 2.16%) ~ 0.896s 1.226s p=0.637 n=40
Bind Time 0.331s (± 3.95%) 0.341s (± 4.47%) ~ 0.291s 0.567s p=0.185 n=40
Check Time 7.609s (± 1.01%) 7.636s (± 1.03%) ~ 7.203s 8.345s p=0.334 n=40
Emit Time 2.324s (± 4.16%) 2.375s (± 4.64%) ~ 2.040s 3.206s p=0.777 n=40
Total Time 11.334s (± 1.16%) 11.436s (± 1.13%) ~ 10.653s 12.703s p=0.089 n=40
webpack - native
Errors 637 637 ~ ~ ~ p=1.000 n=40
Symbols 918,659 918,659 ~ ~ ~ p=1.000 n=40
Types 646,502 646,502 ~ ~ ~ p=1.000 n=40
Memory Used 735,591k (± 0.01%) 735,674k (± 0.01%) ~ 735,125k 736,324k p=0.162 n=40
Memory Allocs 6,383,079 (± 0.05%) 6,389,508 (± 0.05%) +6,020 (+ 0.09%) 6,375,834 6,423,256 p=0.006 n=40
Config Time 0.003s 0.003s ~ ~ ~ p=1.000 n=40
Parse Time 0.129s (± 1.65%) 0.127s (± 1.72%) ~ 0.114s 0.144s p=0.111 n=40
Bind Time 0.042s (± 6.51%) 0.045s (± 7.78%) ~ 0.034s 0.067s p=0.242 n=40
Check Time 1.574s (± 1.02%) 1.571s (± 0.58%) ~ 1.531s 1.657s p=0.885 n=40
Emit Time 0.000s 0.000s ~ ~ ~ p=1.000 n=40
Total Time 1.773s (± 0.93%) 1.770s (± 0.56%) ~ 1.713s 1.864s p=0.995 n=40
xstate-main - native
Errors 1 1 ~ ~ ~ p=1.000 n=40
Symbols 3,978,729 3,978,729 ~ ~ ~ p=1.000 n=40
Types 4,012,886 4,012,886 ~ ~ ~ p=1.000 n=40
Memory Used 2,161,939k (± 0.00%) 2,161,863k (± 0.01%) ~ 2,161,042k 2,162,545k p=0.705 n=40
Memory Allocs 42,791,994 (± 0.01%) 42,885,167 (± 0.01%) +93,452 (+ 0.22%) 42,868,660 42,916,677 p=0.000 n=40
Config Time 0.002s (± 2.38%) 0.002s (± 0.19%) ~ 0.002s 0.002s p=1.000 n=40
Parse Time 0.108s (± 1.87%) 0.108s (± 1.52%) ~ 0.095s 0.121s p=0.955 n=40
Bind Time 0.041s (± 6.55%) 0.042s (± 7.38%) ~ 0.034s 0.063s p=0.964 n=40
Check Time 4.361s (± 0.51%) 4.381s (± 0.46%) ~ 4.254s 4.504s p=0.112 n=40
Emit Time 0.000s 0.000s ~ ~ ~ p=1.000 n=40
Total Time 4.519s (± 0.47%) 4.541s (± 0.44%) ~ 4.427s 4.659s p=0.068 n=40
System info unknown
Hosts
  • native
Scenarios
  • Compiler-Unions - native
  • angular-1 - native
  • arktype - native
  • class-transformer - native
  • effect - native
  • mui-docs - native
  • sentry - native
  • social-app - native
  • strada-build-src - native
  • strada-compiler - native
  • t3code-server - native
  • tanstack-router - native
  • ts-pre-modules - native
  • vscode - native
  • webpack - native
  • xstate-main - native
Benchmark Name Iterations
Current pr 20
Baseline baseline 20

Developer Information:

Download Benchmarks

@typescript-automation

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey) Here are the results of running the top 400 repos with tsc comparing baseline and pr:

Everything looks good!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author: Team For Backlog Bug PRs that fix a backlog bug

Projects

Status: Not started

Development

Successfully merging this pull request may close these issues.

Go checker: finite indexed-access constraint loses its explicit bound depending on prior file checking

2 participants