Skip to content

[10.x] backport src: add node_process.cc - #21799

Closed
jasnell wants to merge 1 commit into
nodejs:v10.x-stagingfrom
jasnell:backport-21105-10x
Closed

jasnell wants to merge 1 commit into
nodejs:v10.x-stagingfrom
jasnell:backport-21105-10x

Conversation

@jasnell

@jasnell jasnell commented Jul 13, 2018

Copy link
Copy Markdown
Member

Backport of #21105

Begin moving process object function definitions out of
node.cc ... continuing the process of making node.cc
smaller and easier to maintain.

PR-URL: #21105
Reviewed-By: Gus Caplan [email protected]
Reviewed-By: Refael Ackermann [email protected]
Reviewed-By: Trivikram Kamat [email protected]
Reviewed-By: Evan Lucas [email protected]
Reviewed-By: Joyee Cheung [email protected]

/cc @addaleax @targos

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Begin moving `process` object function definitions out of
`node.cc` ... continuing the process of making `node.cc`
smaller and easier to maintain.

PR-URL: nodejs#21105
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. c++ Issues and PRs that require attention from people who are familiar with C++. v10.x labels Jul 13, 2018
@jasnell

jasnell commented Jul 13, 2018

Copy link
Copy Markdown
Member Author

@targos

targos commented Jul 14, 2018

Copy link
Copy Markdown
Member

@targos

targos commented Jul 14, 2018

Copy link
Copy Markdown
Member

Got another osx failure. Trying again: https://ci.nodejs.org/job/node-test-pull-request/15874/

targos pushed a commit that referenced this pull request Jul 14, 2018
Begin moving `process` object function definitions out of
`node.cc` ... continuing the process of making `node.cc`
smaller and easier to maintain.

PR-URL: #21105
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>

Backport-PR-URL: #21799
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@targos

targos commented Jul 14, 2018

Copy link
Copy Markdown
Member

Landed in a68b7dd. Thank you @jasnell

@targos targos closed this Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants