Skip to content

worker: keep stdio after exit - #26017

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:worker-stdio-keep
Closed

addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:worker-stdio-keep

Conversation

@addaleax

@addaleax addaleax commented Feb 9, 2019 •

Copy link
Copy Markdown
Member

This addresses review comments from #25871.

Refs: #25871

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

This addresses review comments from
nodejs#25871.

Refs: nodejs#25871
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot nodejs-github-bot added the worker Issues and PRs related to the worker_threads module and Worker API. label Feb 9, 2019
@addaleax

addaleax commented Feb 9, 2019

Copy link
Copy Markdown
Member Author

@addaleax addaleax added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Feb 9, 2019
@addaleax

Copy link
Copy Markdown
Member Author

@addaleax

Copy link
Copy Markdown
Member Author

Landed in 9e84a26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. worker Issues and PRs related to the worker_threads module and Worker API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants