Repository navigation
Conversation
|
It's worth noting that Duplex already has some getters for _writableState. Does this need to be moved to writable.prototype? I'm also looking for a way to proxy all _writableState properties at once, without losing readability and conciseness. |
They are also on Lines 42 to 46 in 187b056 non enumerable properties are skipped, so we have to redefine them. |
|
@zero1five I think this PR should be split in two logical changes/commits:
What do you think? |
|
@lpinca Ok, I feel good. i will update this PR later to update this section with relevant tests. And then see what else is being used. (a little curiosity 🗿, why does Duplex prototype set skip non enumerable properties?) |
|
@zero1five I'm not sure, I think that with a little care we can use |
868f2f1 to
6ce51da
Compare
|
Hmmm...🏊♂️ i made some changes to add getter with relevant tests for Duplex and Writable.
Because this PR is mainly to modify http2, so other changes should be modified in the new PR. |
|
LGTM but can you please move the http2 change to a separate commit? Thank you. |
6ce51da to
cdb22c4
Compare
|
@lpinca 👌 |
|
LGTM |
BridgeAR
left a comment
There was a problem hiding this comment.
This needs some documentation. Otherwise it's LGTM.
d54a111 to
de53445
Compare
|
@BridgeAR Added the doc, PTAL. |
mcollina
left a comment
There was a problem hiding this comment.
Good work! I’ve just added a nit on the doc!
f1d35d4 to
12622a5
Compare
|
Can someone please trigger a CI build? |
284f714 to
2c66f6c
Compare
|
Windows re-build: https://ci.nodejs.org/job/node-test-commit-windows-fanned/28330/ |
|
Landed in 2bb93e1...f11a4ec |
add a new getter to duplex stream to replace the property `this .writableState.finished` of the object that inherited duplex. Refs: nodejs#445 PR-URL: nodejs#28007 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: nodejs#28007 Refs: nodejs#445 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Node 12.4.0 has already been released. Replace the version with REPLACEME so that the proper version gets inserted at release time. Refs: nodejs#28007
commented
Sep 3, 2019
|
@nodejs/http2, should this land on v10.x? Please add the 'lts-watch' label if so |
commented
Sep 4, 2019
|
@BethGriggs yes please, I've added the tag. |
add a new getter to duplex stream to replace the property
this .writableState.finishedof the object that inherited duplex.Refs: #445
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes