Skip to content

doc,n-api: fix metadata for napi_create_threadsafe_function - #28410

Merged
richardlau merged 1 commit into
nodejs:masterfrom
richardlau:napi-docs
Jun 24, 2019
Merged

richardlau merged 1 commit into
nodejs:masterfrom
richardlau:napi-docs

Conversation

@richardlau

Copy link
Copy Markdown
Member

Refs: #27791

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. node-api Issues and PRs related to Node-API. labels Jun 24, 2019
@cjihrig

cjihrig commented Jun 24, 2019

Copy link
Copy Markdown
Contributor

👍 to fast tracking this.

@richardlau

Copy link
Copy Markdown
Member Author

@richardlau richardlau added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jun 24, 2019
@Trott Trott added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Jun 24, 2019

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PR-URL: nodejs#28410
Refs: nodejs#27791
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@richardlau

Copy link
Copy Markdown
Member Author

Landed in 88db3e4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. node-api Issues and PRs related to Node-API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants