Skip to content

doc: document behavior for once(ee, 'error') - #34225

Closed
jasnell wants to merge 2 commits into
nodejs:masterfrom
jasnell:fix-for-31244
Closed

jasnell wants to merge 2 commits into
nodejs:masterfrom
jasnell:fix-for-31244

Conversation

@jasnell

@jasnell jasnell commented Jul 6, 2020

Copy link
Copy Markdown
Member

Fixes: #31244

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. events Issues and PRs related to EventEmitter and the events module. labels Jul 6, 2020
@addaleax addaleax added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jul 7, 2020
trivikr
trivikr previously requested changes Jul 9, 2020
Comment thread doc/api/events.md Resolved
@trivikr trivikr removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jul 9, 2020
Comment thread doc/api/events.md Resolved
Co-authored-by: Luigi Pinca <[email protected]>
@jasnell jasnell added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jul 9, 2020
jasnell added a commit that referenced this pull request Jul 9, 2020
Fixes: #31244

PR-URL: #34225
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@jasnell

jasnell commented Jul 9, 2020

Copy link
Copy Markdown
Member Author

Landed in 949d1c1

@jasnell jasnell closed this Jul 9, 2020
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
Fixes: #31244

PR-URL: #34225
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 14, 2020
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
Fixes: #31244

PR-URL: #34225
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
codebytere pushed a commit that referenced this pull request Sep 27, 2020
Fixes: #31244

PR-URL: #34225
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 28, 2020
Fixes: #31244

PR-URL: #34225
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. events Issues and PRs related to EventEmitter and the events module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify behaviour when listening for 'error' event using once()

5 participants