Skip to content

[v26.x] lib: move _http_* to internal/http - #67546

Open
aduh95 wants to merge 2 commits into
nodejs:v26.x-stagingfrom
aduh95:emove-http-files
Open

aduh95 wants to merge 2 commits into
nodejs:v26.x-stagingfrom
aduh95:emove-http-files

Conversation

@aduh95

@aduh95 aduh95 commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Annoyingly #58535 was landed as a single commit, resulting in annoying conflicts on v26.x. This commit is to help with that. I've ran the following to generate this PR:

mkdir lib/internal/http
for f in $(find lib -maxdepth 1 -name '_http_*'); do
  new_file=$(sed -E 's#_http_#internal/http/#' <<EOF
$f
EOF
)
  git mv "$f" "$new_file"
  { echo "'use strict';";echo;echo "module.exports = require('internal/http/$(basename "$new_file" .js)');" } > "$f"
done

Using two commits so git-blame can still track changes.

@aduh95 aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Nov 17, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http Issues and PRs related to the http subsystem. needs-ci PRs that need a full CI run. v26.x Issues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch. labels Nov 17, 2026
@aduh95
aduh95 force-pushed the v26.x-staging branch 4 times, most recently from e578ab4 to 5cdbf45 Compare November 17, 2026 16:34
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codecov

codecov Bot commented Nov 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.46731% with 153 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.92%. Comparing base (ca26282) to head (9a6a49a).
⚠️ Report is 1614 commits behind head on v26.x-staging.

Files with missing lines Patch % Lines
lib/internal/http/server.js 96.75% 47 Missing and 3 partials ⚠️
lib/internal/http/client.js 97.37% 34 Missing ⚠️
lib/internal/http/outgoing.js 97.97% 28 Missing and 2 partials ⚠️
lib/internal/http/agent.js 97.01% 22 Missing ⚠️
lib/internal/http/incoming.js 97.64% 14 Missing and 1 partial ⚠️
lib/internal/http/common.js 99.42% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           v26.x-staging   #67546      +/-   ##
=================================================
+ Coverage          90.24%   90.92%   +0.68%     
=================================================
  Files                729      781      +52     
  Lines             242760   275765   +33005     
  Branches           46044    53031    +6987     
=================================================
+ Hits              219073   250748   +31675     
- Misses             15133    15801     +668     
- Partials            8554     9216     +662     
Files with missing lines Coverage Δ
lib/_http_agent.js 100.00% <100.00%> (+3.39%) ⬆️
lib/_http_client.js 100.00% <100.00%> (+2.36%) ⬆️
lib/_http_common.js 100.00% <100.00%> (+0.57%) ⬆️
lib/_http_incoming.js 100.00% <100.00%> (+2.08%) ⬆️
lib/_http_outgoing.js 100.00% <100.00%> (+2.23%) ⬆️
lib/_http_server.js 100.00% <100.00%> (+3.53%) ⬆️
lib/internal/http/common.js 99.42% <99.42%> (ø)
lib/internal/http/incoming.js 97.64% <97.64%> (ø)
lib/internal/http/agent.js 97.01% <97.01%> (ø)
lib/internal/http/outgoing.js 97.97% <97.97%> (ø)
... and 2 more

... and 437 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pimterry pimterry added the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Nov 18, 2026
@github-actions github-actions Bot removed the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Nov 18, 2026

@gurgunday gurgunday left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pimterry pimterry added the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Nov 18, 2026
@aduh95 aduh95 removed the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Nov 18, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. http Issues and PRs related to the http subsystem. needs-ci PRs that need a full CI run. v26.x Issues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants