Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing
TabStop.positionreplaces its XML node. If two references were obtained for that tab stop, moving one leaves the other attached to the removed node: setting a dot leader through the earlier reference silently loses that change when the document is saved. The moved proxy's.elementalso continues to refer to the removed node.Reinsert the existing node in position order, using the same ordering helper for new and moved tab stops. Existing references then see the new position and continue to modify the document. Tests cover node identity, negative positions, ties, and persistence of a leader edit through an earlier reference after saving and reopening the document. Seven regression cases fail on master
e454546and pass with the fix.Validation on macOS arm64 / Python 3.13.2:
python -m pytest -q: 1,611 passed.python -m behave --format progress --stop --tags=-wip: 650 scenarios / 1,856 steps passed.git diff --checkpass.The test environment uses pytest 8.4.2 and pyparsing 3.2.3, which satisfy the declared development dependencies. Installing pyparsing 3.3.3 instead causes an existing deprecated
delimitedListcall in the test helper to fail collection under warnings-as-errors. Other platforms and Word rendering were not tested.AI disclosure: OpenAI Codex investigated the bug, prepared and reviewed the patch, and ran the reported checks.