You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
In ./Doc, "make html" and "make build" should depend on "make venv" #88919
In Doc/Makefile, all of the build rules should be dependent on the existence of a virtual environment. I could see this being controversial, because folks who have these tools installed elsewhere might prefer not to have a venv made for them, but my personal workflow is to strive to keep my system site-packages folder as empty as possible and to use virtual environments frequently. In any case, I'm interested to hear what we think.
Momentarily, I will attach a PR where I went ahead and made these changes. Here is a summary of the changes:
venv rule is now conditional, and only does anything if $VENVDIR does
not exist
add rule "clean-venv". This can be removed – what do you all think?
build rule is dependent on venv
as a result, rules dependent on build are dependent on venv
html
latex
etc.
update Doc/README.rst appropriately. Now users only need to type make html – nice!
Let me know what you think. I may have a blind spot to others' workflows! Also, I'm not a Windows user, so I have no insight as to whether make.bat needs to be updated as well.
New changeset 55fa87b by Łukasz Langa in branch 'main': bpo-44756: [docs] revert automated virtual environment creation on make html (GH-27635) 55fa87b
New changeset 91f6d38 by Miss Islington (bot) in branch '3.9': bpo-44756: [docs] revert automated virtual environment creation on make html (GH-27635) (GH-27636) 91f6d38
New changeset 1e9c9ca by Miss Islington (bot) in branch '3.10': bpo-44756: [docs] revert automated virtual environment creation on make html (GH-27635) 1e9c9ca
New changeset 5246dbc by Łukasz Langa in branch 'main': bpo-44756: Remove misleading NEWS entries of a change that was reverted before release (GH-28075) 5246dbc
New changeset 9ef1843 by Łukasz Langa in branch '3.9': bpo-44756: Remove misleading NEWS entries of a change that was reverted before release (GH-28075) 9ef1843
Activity
jdevries3133 commentedon Jul 28, 2021
In Doc/Makefile, all of the build rules should be dependent on the existence of a virtual environment. I could see this being controversial, because folks who have these tools installed elsewhere might prefer not to have a venv made for them, but my personal workflow is to strive to keep my system site-packages folder as empty as possible and to use virtual environments frequently. In any case, I'm interested to hear what we think.
Momentarily, I will attach a PR where I went ahead and made these changes. Here is a summary of the changes:
not exist
make html– nice!Let me know what you think. I may have a blind spot to others' workflows! Also, I'm not a Windows user, so I have no insight as to whether
make.batneeds to be updated as well.ambv commentedon Jul 28, 2021
New changeset d22c876 by Jack DeVries in branch 'main':
bpo-44756: in ./Doc,
make builddepends onmake html(bpo-27403)d22c876
ambv commentedon Jul 28, 2021
New changeset f113195 by Miss Islington (bot) in branch '3.10':
bpo-44756: in ./Doc,
make builddepends onmake html(GH-27403) (GH-27410)f113195
ambv commentedon Jul 28, 2021
New changeset fd2c246 by Miss Islington (bot) in branch '3.9':
bpo-44756: in ./Doc,
make builddepends onmake html(GH-27403) (GH-27411)fd2c246
ambv commentedon Jul 28, 2021
Thanks, Jack! ✨ 🍰 ✨
10 remaining items
ambv commentedon Aug 6, 2021
New changeset 55fa87b by Łukasz Langa in branch 'main':
bpo-44756: [docs] revert automated virtual environment creation on
make html(GH-27635)55fa87b
ambv commentedon Aug 6, 2021
New changeset 91f6d38 by Miss Islington (bot) in branch '3.9':
bpo-44756: [docs] revert automated virtual environment creation on
make html(GH-27635) (GH-27636)91f6d38
miss-islington commentedon Aug 6, 2021
New changeset 1e9c9ca by Miss Islington (bot) in branch '3.10':
bpo-44756: [docs] revert automated virtual environment creation on
make html(GH-27635)1e9c9ca
ambv commentedon Aug 6, 2021
Revert done. Re-closing!
ambv commentedon Aug 30, 2021
New changeset 5246dbc by Łukasz Langa in branch 'main':
bpo-44756: Remove misleading NEWS entries of a change that was reverted before release (GH-28075)
5246dbc
ambv commentedon Aug 30, 2021
New changeset 9ef1843 by Łukasz Langa in branch '3.9':
bpo-44756: Remove misleading NEWS entries of a change that was reverted before release (GH-28075)
9ef1843