Repository navigation
gh-116245: Document getentropy() use in os.urandom() - #162108
Open
kirtiagwl1595 wants to merge 1 commit into
Open
kirtiagwl1595 wants to merge 1 commit into
kirtiagwl1595 wants to merge 1 commit into
Conversation
Comment on lines
+6469
to
+6476
| On other Unix-like systems, the C ``getrandom()`` or ``getentropy()`` | ||
| function is used if it is available, for example ``getentropy()`` on OpenBSD | ||
| and on macOS 10.12 and newer. | ||
|
|
||
| On any Unix-like system, if none of these functions can be used, random | ||
| bytes are read from the ``/dev/urandom`` device. If the ``/dev/urandom`` | ||
| device is not available or not readable, the :exc:`NotImplementedError` | ||
| exception is raised. |
Member
There was a problem hiding this comment.
Suggested change
| On other Unix-like systems, the C ``getrandom()`` or ``getentropy()`` | |
| function is used if it is available, for example ``getentropy()`` on OpenBSD | |
| and on macOS 10.12 and newer. | |
| On any Unix-like system, if none of these functions can be used, random | |
| bytes are read from the ``/dev/urandom`` device. If the ``/dev/urandom`` | |
| device is not available or not readable, the :exc:`NotImplementedError` | |
| exception is raised. | |
| On other Unix-like systems, the C ``getrandom()`` function is used if it is | |
| available, otherwise the C ``getentropy()`` function. | |
| If none of these functions can be used, random bytes are read from the | |
| ``/dev/urandom`` device. If the ``/dev/urandom`` device is not available or | |
| not readable, the :exc:`NotImplementedError` exception is raised. |
We're duplicating "Unix-like system" and we don't state the order in which we check the functions. Also, I don't think we need the OpenBSD/macOS implementation detail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As Ronald Oussoren explained in the issue,
os.urandom()usesgetentropy()on macOS 10.12 and newer and on OpenBSD, but the docs mention only/dev/urandomfor Unix-like systems;getentropy()appears only in a 3.5versionchangednote. This change follows that diagnosis, not the issue title:CCRandomGenerateBytesis not used. The Unix paragraph now namesgetrandom()andgetentropy(), and keeps the/dev/urandomfallback for all Unix-like systems, which matchespyurandom()inPython/bootstrap_hash.c.This needs the skip news label (docs only).
I used Claude Code to research and draft this change; I reviewed every line.