Repository navigation
Conversation
The docstring and the documentation said that the string "is returned as-is" when neither charset nor language is given. The function always percent-encodes the string, as RFC 2231 requires for characters such as the space. Without charset and language it only leaves out the charset'language' prefix. The behavior is correct and is not changed.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docstring and
Doc/library/email.utils.rststate that if no charset or language is provided then the string "is returned as-is". But:As noted by bitdancer in GH-20564, the docstring is incorrect and the code is correct. A blank must be percent-encoded in an RFC 2231 value. The code was updated in that PR, but it was closed. This PR only updates the two descriptions. The string is always percent-encoded. If no charset or language is provided then there will be no
charset'language'prefix.No functional changes, so no test or NEWS entry. In GH-161225 the core of the function is being changed for gh-161222. These lines aren't touched.