Skip to content

gh-161767: Fix crash in PyDict_AsFrozenDictAndClear on embedded values - #162139

Open
sobolevn wants to merge 4 commits into
python:mainfrom
sobolevn:issue-161767
Open

sobolevn wants to merge 4 commits into
python:mainfrom
sobolevn:issue-161767

Conversation

@sobolevn

@sobolevn sobolevn commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

My alternative to #161768

I've also added more tests for dicts with non-str keys. Because they are a bit different now. str keys take less memory. It is worth testing.

self.assertIs(type(d), dict)
self.assertEqual(d, {})

d = DictSubtype({1: 'a', 2: 'b', 3: 'c', None: 'f'})

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you add this test, is it still useful to keep d = DictSubtype(x=123) test above?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that yes, because we need to test both str and non-str keys.

Comment thread Lib/test/test_capi/test_dict.py Resolved
Comment thread Lib/test/test_capi/test_dict.py Resolved
Comment thread Objects/dictobject.c Resolved
@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #35948106 | 📁 Comparing 57bdb7e against main (4497fe9)

  🔍 Preview build  

1 file changed
± c-api/dict.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants