Repository navigation
gh-129813: Use PyBytesWriter in ctypes - #162260
Merged
Merged
Conversation
Contributor
Author
|
cc @vstinner Another one in the today's series, inspired by |
vstinner
approved these changes
Nov 19, 2026
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM. Straightforward usage of the PyBytesWriter API.
It should be faster. The old code uses 2 heap memory allocations (PyMem_Malloc + PyBytes_FromStringAndSize) and had to copy bytes once (buffer => bytes). With the updated code, there is a single heap memory allocation, and bytes are only copied if the bytes object is smaller than 256 (PyBytesWriter uses a "small buffer" in this case). So for large bytes objects, bytes are written once and not copied.
Member
|
Reducing the peak memory usage by a factor of 2 is great! Also, the slice operation is up to 1.10x faster than before, which is also nice to have. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Write strided slices of
c_chararrays and pointers w/ aPyBytesWriter. Spares a temporary allocation, a copy. Similar to #162257I believe this is mostly a simplification, but, again, I'm surprised that's good for the memory:
pyperf:
(PGO+LTO, macOS arm64)
pyperf
memory