Repository navigation
bpo-40592: shutil.which will not return None anymore if ; is the last char in PATHEXT - #20088
Conversation
commented
May 14, 2020
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
…thon into fix-shutil-which-windows
commented
May 18, 2020
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Steve Dower <[email protected]>
commented
May 19, 2020
|
I have made the requested changes; please review again |
commented
May 19, 2020
|
Thanks for making the requested changes! @zooba: please review the changes made to this pull request. |
commented
Jul 6, 2020
|
@zooba Could you please re-review the changes and provide feedback? |
commented
Oct 21, 2020
|
@zooba Added the requested changes :) |
This reverts commit 6af00e7.
|
@zooba Currently, the test pipeline fails with the following message:
That's pretty odd as other tests, like |
commented
Oct 22, 2020
|
You might need to merge from upstream, I think someone rearranged the test helpers. The PR checks are going to run against the merge result, but if there are no direct conflicts then it won't warn that you made the changes against an older version. |
commented
Oct 22, 2020
|
@zooba Silly me, fixed it! Thank you! |
commented
Oct 23, 2020
|
Thanks @peanutlord for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
commented
Oct 23, 2020
|
GH-22912 is a backport of this pull request to the 3.9 branch. |
commented
Oct 23, 2020
|
GH-22913 is a backport of this pull request to the 3.8 branch. |
commented
Oct 23, 2020
|
Additional note: created a new
test_pathext_with_empty_str()test, but copies roughly 10loc fromtest_pathext(). We could also add theassertEqualwith a newwithblock to thetest_pathext.https://bugs.python.org/issue40592