Repository navigation
gh-91317: Document that Path does not collapse initial // - #32193
Conversation
…esHfS.rst Co-authored-by: Jelle Zijlstra <[email protected]>
|
/cc @barneygale |
|
The present documentation is technically correct, but could be more complete. The word "spurious" does a lot of work. On POSIX paths: According to POSIX path resolution:
You can try it for yourself in a shell: This isn't mentioned anywhere in the pathlib docs, but it could be! I think this would best addressed by a new paragraph and repl example in the documentation for Note that this has nothing to do with UNC paths! :-) On Windows paths: The docs for UNC paths sit at about the right place for me - in the details for
|
MaxwellDupre
left a comment
There was a problem hiding this comment.
It would have been better to spilt the sentence in two for non-English readers for clarity.
commented
Jun 7, 2022
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Brett Cannon <[email protected]>
////
commented
Jun 8, 2022
|
I'm working on the barneygale's review. |
Co-authored-by: Barney Gale <[email protected]>
commented
Jun 8, 2022
|
@barneygale I have made the requested changes; please review again. I hope I didn't make grammar mistakes there. |
commented
Jun 8, 2022
|
Thanks for making the requested changes! @brettcannon: please review the changes made to this pull request. |
commented
Jun 10, 2022
|
Thanks @arhadthedev for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
commented
Jun 10, 2022
|
GH-93702 is a backport of this pull request to the 3.11 branch. |
commented
Jun 10, 2022
|
GH-93703 is a backport of this pull request to the 3.10 branch. |
commented
Jun 10, 2022
|
@arhadthedev thanks! |
Documentation for
pathlibsays:However, it omits that initial double slashes also aren't collapsed.
Later, in documentation of
PurePath.drive,PurePath.root, andPurePath.nameit mentions UNC but:For context, see the BPO entry.
https://bugs.python.org/issue47161
Automerge-Triggered-By: GH:brettcannon