Repository navigation
feat(audit): name provider, credential, config, and draft policy resources - #5612
Merged
krishicks merged 1 commit intoNov 19, 2026
Merged
Conversation
3 of 5 tasks
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
🌿 Preview your docs: https://nvidia-preview-pr-5612.docs.buildwithfern.com/openshell |
krishicks
force-pushed
the
feat/2911-name-provider-config-resources/krishicks
branch
from
November 16, 2026 18:51
f15643e to
e82dc72
Compare
Base automatically changed from
feat/2911-name-created-resources/krishicks
to
main
November 17, 2026 19:32
4 tasks
krishicks
force-pushed
the
feat/2911-name-provider-config-resources/krishicks
branch
from
November 18, 2026 21:26
e82dc72 to
181799f
Compare
krishicks
marked this pull request as ready for review
November 18, 2026 21:26
TaylorMutch
reviewed
Nov 18, 2026
…urces Records for provider, credential, configuration, and draft policy changes named nothing, so an auditor could not tell which provider, credential key, setting, or draft chunk a call changed, and could not see the value a setting was given. Name the provider and credential key, the sandbox and setting key, and the sandbox and draft chunks, plus the resulting policy hash. Add [openshell.gateway.audit] capture_setting_values to record the value of a registered setting when it has the registered type. Credential values, refresh material, review tokens, rejection reasons, and proposed rules are never recorded, and canary tests cover each. A record over the resource cap keeps its last resource, the result of the change, and authorization denials apply the same cap and value bounds. Signed-off-by: Kris Hicks <khicks@nvidia.com>
krishicks
force-pushed
the
feat/2911-name-provider-config-resources/krishicks
branch
from
November 18, 2026 23:17
181799f to
064825c
Compare
TaylorMutch
approved these changes
Nov 19, 2026
TaylorMutch
left a comment
Collaborator
There was a problem hiding this comment.
Verified the denial-path fix in 064825c. Both mutation and authorization-denial events now share the resource-count and field limits. All 27 audit tests passed locally, including an independent handler-level reproduction using a 4,096-byte setting value, which is now bounded to 128 bytes plus the truncation marker.
krishicks
deleted the
feat/2911-name-provider-config-resources/krishicks
branch
November 19, 2026 00:45
mrunalp
added a commit
that referenced
this pull request
Nov 19, 2026
…ecrets/mrunalp Take main's generated default handlers (#5733) in the CLI test servers, which drops this branch's hand-written secret RPC stubs there. Combine the audit imports with #5612, and record the refreshed provider for InlineProviderRefreshSecrets the same way as ConfigureProviderRefresh and RotateProviderCredential. Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Records for provider, credential, configuration, and draft policy changes name nothing, so an auditor cannot tell which provider, credential key, setting, or draft chunk a call changed. They now name those resources and the resulting policy hash. A new opt-in setting records the value a setting was given. Secrets never appear.
Stacked on #5611; review only the last commit until the PRs below it merge.
Related Issue
Part of #2911
Changes
CreateProvider,UpdateProvider,ConfigureProviderRefresh,RotateProviderCredential,UpdateConfig, and the draft chunk RPCs name the provider, credential key, sandbox, setting key, and chunk IDs. Policy changes, draft approvals, and undo name the resulting policy by its hash asuid.no_op:already_absent, clearing no draft chunks recordsno_op:already_absent, and a bulk approval that approves nothing recordsno_op:unchanged.[openshell.gateway.audit] capture_setting_values(defaultfalse) records the value of a registered setting in the resource'sdata, only when the value has the setting's type. Bytes values and unregistered keys are never recorded.openshell-ocsf:ResourceDetailsgains an optionaldatafield.Before / after
Real OCSF output from the gateway handlers, called by the test user in workspace
default. Each credential and review token below was a canary string that appears in no record.CreateProvider openaiwithOPENAI_API_KEY→ OKworkspace:default,provider:openaiwith its IDRotateProviderCredential openai/OPENAI_API_KEY, no refresh configuredrejected:not_found, no resourcesworkspace:default,provider:openai,provider_credential:OPENAI_API_KEYUpdateConfigglobalocsf_json_enabled = truesetting:ocsf_json_enabledcapture_setting_values = truesetting:ocsf_json_enabledwithdata: {"value": true}ApproveDraftChunk chunk-7onagent-01, absentrejected:not_found, no resourcesworkspace:default,sandbox:agent-01,draft_chunk:chunk-7Release Notes
Gateway audit records now name the provider, credential key, setting, and draft chunks a call changed. Set
capture_setting_values = trueunder[openshell.gateway.audit]to also record setting values.Testing
Checklist