Skip to content

test(grpc): generate default handlers for partial test servers - #5733

Merged
TaylorMutch merged 2 commits into
mainfrom
refactor/5732-grpc-test-mocks/TaylorMutch
Nov 19, 2026
Merged

TaylorMutch merged 2 commits into
mainfrom
refactor/5732-grpc-test-mocks/TaylorMutch

Conversation

@TaylorMutch

Copy link
Copy Markdown
Collaborator

Summary

Adding a gateway RPC currently requires unused handler implementations across CLI test servers. Generate default UNIMPLEMENTED handlers for partial test servers and remove 2,244 lines net, while keeping production service traits exhaustive.

Related Issue

Closes #5732

Changes

  • Generate a separate server behind openshell-server's test-support feature using Tonic defaults and existing openshell-core wire types.
  • Migrate six synthetic CLI gateway fixtures and remove the hand-maintained template RPC stub macro, preserving intentional custom errors and stream behavior.
  • Cover omitted unary and all streaming RPC shapes with a production client, guard production trait exhaustiveness with a compile-fail doctest, and document the helper.

Release Notes

Testing

  • Checks appropriate to the affected code and behavior pass: strict Clippy for the server test-support library and seven affected CLI integration targets; formatting, lockfile validation, and diff whitespace checks.
  • Integration tests added/updated: 164 passed across seven affected CLI suites; two pre-existing ignored tests.
  • Production-trait compile-fail doctest passes.
  • E2E tests: not applicable to this test infrastructure cleanup.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Test-helper usage documented in the server crate README; no architecture changes.

@copy-pr-bot

copy-pr-bot Bot commented Nov 18, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the state:accepted A maintainer decided OpenShell should pursue this issue label Nov 18, 2026
@TaylorMutch TaylorMutch added area:platform SDKs, CLIs, APIs, gateway infrastructure, persistence, configuration, and session management. topic:dx Making OpenShell easy to contribute to for humans and agents. topic:testing Unit, integration, regression, conformance, E2E tests, coverage, flakes, and test infrastructure. labels Nov 18, 2026
@TaylorMutch
TaylorMutch marked this pull request as ready for review November 18, 2026 23:59
@purp purp assigned purp and unassigned purp Nov 19, 2026
@TaylorMutch
TaylorMutch added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit fd3cff6 Nov 19, 2026
101 of 105 checks passed
@TaylorMutch
TaylorMutch deleted the refactor/5732-grpc-test-mocks/TaylorMutch branch November 19, 2026 01:46
mrunalp added a commit that referenced this pull request Nov 19, 2026
…ecrets/mrunalp

Take main's generated default handlers (#5733) in the CLI test servers,
which drops this branch's hand-written secret RPC stubs there. Combine the
audit imports with #5612, and record the refreshed provider for
InlineProviderRefreshSecrets the same way as ConfigureProviderRefresh and
RotateProviderCredential.

Signed-off-by: Mrunal Patel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:platform SDKs, CLIs, APIs, gateway infrastructure, persistence, configuration, and session management. state:accepted A maintainer decided OpenShell should pursue this issue topic:dx Making OpenShell easy to contribute to for humans and agents. topic:testing Unit, integration, regression, conformance, E2E tests, coverage, flakes, and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(grpc): reduce unused handlers in CLI gateway mocks

3 participants