Repository navigation
feat(providers): support basic client auth and resource in OAuth refresh - #5668
Conversation
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
|
PTAL when you get a chance, and |
|
Full SHA for the gate: |
|
/ok to test 80fed52 |
|
Label |
PR Review StatusThe independent review found no blocking issues in the OAuth request builder, configuration validation, dependency wiring, tests, or docs. @ericcurtin, I checked the full head SHA you supplied, applied Blocking findings:
Carried findings:
Non-blocking suggestions:
Gator metadata
|
Monitoring CompleteMonitoring is complete because this PR has merged. Final status: The current head already received a Gator review with no blocking findings, and maintainer approval was present before merge. I removed the active |
…ecrets/mrunalp Resolve the schema inventory conflict with #4732 by combining the RPC counts and recomputing the reviewed public fingerprint. Adapt to #5668, which added Basic client authentication to OAuth refresh: count a client_secret supplied by a workspace secret as present when validating token_endpoint_auth_method, and test a Basic mint whose client secret comes from a workspace secret. Update the new request_token test and refresh request literal for the merged signatures. Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
Summary
OAuth refresh providers can now use
client_secret_basicand send an RFC 8707resourceindicator.Related Issue
Closes #5663
Changes
token_endpoint_auth_methodandresourcematerial keys.Release Notes
Refresh providers accept
token_endpoint_auth_method=client_secret_basicandresource=<uri>. Defaults are unchanged.Testing
Minter, server and docs checks pass, and clippy is clean on the credential issuer.
Checklist